feat: use promises in callbacks + cleanup #1160
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the usage of promises in our callbacks. Meaning we can now trigger callbacks in this manner:
Without loosing compatibility with the old format:
This also introduces the
QBCore.Shared.IsFunction
function, to check whether a value is a function OR a funcref!Only thing I'm a bit unsure about here, would be the fact that functions become funcrefs, which cant be checked viatype()
, as they returntable
instead offunction
. The solution here is a bit hacky, but the only real "good" way would be the PR fivem and add some kind of function to check whether a value is a funcref or not.Checklist